devel/libical: Improve port

* Replace PORTVERSION with DISTVERSION
* Enable "make test"
* Remove local patch
* Some layout changes to port Makefile

PR:		283554
Reviewed by:	desktop (arrowd)

devel/libical/Makefile

@@ -1,7 +1,8 @@
 PORTNAME=	libical
 DISTVERSION=	3.0.19
+PORTREVISION=	1
 CATEGORIES=	devel
-MASTER_SITES=	https://github.com/libical/libical/releases/download/v${PORTVERSION}/
+MASTER_SITES=	https://github.com/libical/libical/releases/download/v${DISTVERSION}/
 
 MAINTAINER=	desktop@FreeBSD.org
 COMMENT=	Implementation of the IETF Calendaring and Scheduling protocols
@@ -12,27 +13,35 @@ LICENSE_COMB=	dual
 
 LIB_DEPENDS=	libicuuc.so:devel/icu
 
-USES=		cmake compiler:c++11-lib cpe gnome pathfix perl5 pkgconfig
+USES=		cmake:testing compiler:c++11-lib cpe gnome pathfix perl5 \
+		pkgconfig
 CPE_VENDOR=	libical_project
 USE_LDCONFIG=	yes
 USE_PERL5=	build
 
 DOCSDIR=	${PREFIX}/share/gtk-doc/html/libical-glib
 
-PLIST_SUB=	VERSION=${PORTVERSION}
+PLIST_SUB=	VERSION=${DISTVERSION}
+
+CMAKE_TESTING_ON=	LIBICAL_BUILD_TESTING
+
+CMAKE_OFF=	LIBICAL_BUILD_TESTING
+CMAKE_ON=	CMAKE_DISABLE_FIND_PACKAGE_BerkeleyDB \
+		CMAKE_DISABLE_FIND_PACKAGE_Doxygen
 
 OPTIONS_DEFINE=		DOCS GLIB INTROSPECTION VAPI
 OPTIONS_DEFAULT=	GLIB INTROSPECTION VAPI
 OPTIONS_SUB=		yes
 
+GLIB_DESC=		Build GLib bindings
+INTROSPECTION_DESC=	Build GObject Introspection
+
 DOCS_BUILD_DEPENDS=	gtkdoc-scan:textproc/gtk-doc
 DOCS_CMAKE_BOOL=	ICAL_BUILD_DOCS
 
-GLIB_DESC=		Build GLib bindings
 GLIB_USE=		GNOME=glib20,libxml2
 GLIB_CMAKE_BOOL=	ICAL_GLIB
 
-INTROSPECTION_DESC=		Build GObject Introspection
 INTROSPECTION_USE=		gnome=introspection:build
 INTROSPECTION_CMAKE_BOOL=	GOBJECT_INTROSPECTION
 

devel/libical/files/patch-src__libical__icaltz-util.c

@@ -1,13 +0,0 @@
---- src/libical/icaltz-util.c.orig	2022-10-17 20:53:57 UTC
-+++ src/libical/icaltz-util.c
-@@ -82,6 +82,10 @@
- #define bswap_64 __builtin_bswap64
- #endif
- 
-+#if defined(__FreeBSD__) && !defined(bswap_64)
-+#define bswap_64(x) __bswap64(x)
-+#endif
-+
- typedef struct
- {
-     char magic[4];