Commit graph

130 commits

Author SHA1 Message Date
Bryan Drewery
d715852bba Don't hardcode CCACHE_DIR.
PR:		199509
Submitted by:	ngie (based on)
Sponsored by:	EMC / Isilon Storage Division
With hat:	portmgr
2015-11-06 20:18:35 +00:00
Bryan Drewery
95e25b27ad Avoid redundantly looking up python command executions for dependency calculation.
This gets all-depends-list in x11/kde4 down to 30 seconds after the 52->41
second improvement in r399703.

With hat:	portmgr
2015-10-19 21:10:56 +00:00
Bryan Drewery
ef91c74363 Avoid redundantly looking up perl version when looking up dependencies or in sub-makes.
With hat:	portmgr
2015-10-19 20:53:15 +00:00
Bryan Drewery
278dd71cd6 - Combine clean-depends-list.sh into depends-list.sh
- Refactor how depends-list.sh is called from bsd.port.mk for each variant.

With hat:	portmgr
2015-10-19 19:23:53 +00:00
Bryan Drewery
670c3111ae The command environment from r399703 is only needed if recursing.
With hat:	portmgr
2015-10-19 18:41:01 +00:00
Bryan Drewery
92b545ba81 When listing dependencies, export the common command execution results.
In some basic benchmarks this sped up 'all-depends-list' about 20%.  x11/kde4
went from 52 seconds to 41 seconds.  More improvement is expected once
more command executions are cached in the 'export_ports_env' function.

With hat:	portmgr
2015-10-19 18:01:56 +00:00
Bryan Drewery
34da0bbb9e Add some work-in-progress scripts for splitting symbols out into PREFIX/lib/debug.
This is only missing the bsd.port.mk pieces to hook it up fully.  A blocker
for hooking that up has been sub-packages, even though some implementation
could be made without them.  For now just commit what I have so it is not
forgotten.

Obtained from:	OneFS
Sponsored by:	EMC / Isilon Storage Division
With hat:	portmgr
2015-10-19 17:04:33 +00:00
Bryan Drewery
16f2336cda Switch strip test to using readelf(1) instead of file(1) to identify symbols.
This has been slightly faster in my tests since readelf(1) will fail on the
file much quicker if it doesn't find the ELF headers.  This also more directly
finds the symbol table.

With hat:	portmgr
2015-10-19 16:59:49 +00:00
Bryan Drewery
481f66bd21 Follow-up r399170 with a script, ports_env.sh, that can be used for the purpose.
This will allow Poudriere to know if it is possible to use the feature or not
by the existence of the file.

Also fix quoting issues.

With hat:	portmgr
2015-10-13 00:03:10 +00:00
Bryan Drewery
6221392fff Add a function to export vars that bsd.port.mk generates from fork/exec.
This will be useful in Poudriere to avoid needless fork/exec for every
port when gathering dependencies.

Example usage:

  MAKE=make sh -c '. Mk/Scripts/functions.sh; export_index_env; export PACKAGE_BUILDING=1; truss -f make -C sysutils/zfstools -V BUILD_DEPENDS 2>&1' | grep exec

This eliminates 14 exec/fork calls for this example, when PACKAGE_BUILDING
is also set during -V.

Care should be taken with UID not being passed down into actual builds as it
may conflict with non-root builds.

With hat:	portmgr
2015-10-12 23:41:36 +00:00
Dmitry Marakasov
7d137fe741 Use -r flag for read command, this fixes handling of paths containing
backslashes, and, in result, stage-qa for archivers/deco

Approved by:	portmgr (antoine)
Differential Revision:	D3862
2015-10-12 13:33:18 +00:00
Bryan Drewery
2ef20de270 Make missing argument less obscure.
With hat:	portmgr
2015-10-09 18:13:57 +00:00
Bryan Drewery
a1a7117c83 Shift any arguments eaten up from getopts. This script takes no arguments
yet.

With hat:	portmgr
2015-10-09 18:09:02 +00:00
Bryan Drewery
78aeec8db1 Unify depends-list.sh and all-depends-list.sh into one script, depends-list.sh.
With hat:	portmgr
2015-10-09 18:00:44 +00:00
Dmitry Marakasov
0521b2fe8e Add a way to cleanly handle terminfo.db file used by devel/ncurses
This database contains compiled terminfo entries and is merged from
a large part which comes with ncurses themselves and compiled
.terminfo files installed by other ports (currently only rxvt-unicode
and jfbterm)

- Now the database is always kept up to date, regardless of port
  installation order (both ncurses installed before .terminfo files
  and the other way around work as expected)
- All affected ports now support clean deinstallation and do not
  produce stage-qa errors
- Affected ports are simplified, as they now only need to define
  USES=terminfo
- rxvt-unicode no longer pulls in ncurses: the dependency is not
  really needed for anything beside updating it's own database
- The patch contains Q/A test to check whether a port needs, or
  needs not USES=terminfo

Approved by:	portmgr (mat, bapt)
Differential Revision:	D3747
2015-10-08 14:12:53 +00:00
Dmitry Marakasov
5c57225987 Implemented complete support for test target.
You can now `make test' on any port to run test sequence, no-op by default.
If a port defines TEST_TARGET, it'll run sub-make with specified target,
usually `check' or `test', useful if upstream supports that. The port may
instead define custom do-test target, as well as usual satellite targets:

  {pre,do,post}-test, {pre,do,post}-test-OPT, {pre,do,post}-test-OPT-off

`make test' builds and stages port first, so test may use both WRKDIR and
STAGEDIR, and both BUILD and RUN depends are available for test target.
Additionally, TEST_DEPENDS is now properly supported and may be used to
define additional depends specifically for testing.

Framework may define default tests for specific cases. For instance,
perl5.mk and cran.mk already provide default test target on their own.

This commit also converts my ports which have tests to this new framework.

Approved by:	portmgr (bapt)
Differential Revision:	D3680
2015-09-28 17:20:42 +00:00
Baptiste Daroussin
5adc8a9faa Extend @sample to accept arguments
Maintainers can now use @sample sample_file target_file for all cases
that does not fall into the usual @sample something.sample

Reviewed by:	antoine
Differential Revision:	https://reviews.freebsd.org/D3734
2015-09-26 12:13:23 +00:00
Baptiste Daroussin
8f2fe367d2 Fix error message when not finding a package 2015-09-02 21:23:47 +00:00
Antoine Brodin
cfff850167 Make baselibs QA check non recursive and activate it again
Reviewed by:	bapt
Differential Revision:	https://reviews.freebsd.org/D3352
2015-08-10 17:06:50 +00:00
Baptiste Daroussin
f575dbf44e Disable baselibs check until it is made saner (aka non recursive) 2015-08-09 11:41:56 +00:00
Antoine Brodin
b11b1637e0 Fix a typo that made baselibs QA check run twice on some files
With hat:	portmgr
2015-08-09 10:10:03 +00:00
Fukang Chen
d5ee3ef661 checks $WRKSRC for all direct dependencies in the limited-clean-depends:
target, like the original CLEAN-DEPENDS-LIMITED in bsd.port.mk

Approved by: bapt
Differential Revision: https://reviews.freebsd.org/D3233
2015-07-30 07:43:49 +00:00
Mathieu Arnold
f08b36d14d Split LIB_DEPENDS and the other _DEPENDS types.
Reviewed by:	bapt, pgolluci
Exp-run by:	mat
Approved by:	bapt
With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3150
2015-07-24 10:11:18 +00:00
Baptiste Daroussin
7b41fe4853 Fix path of libedit 2015-07-19 22:19:37 +00:00
Baptiste Daroussin
81e9ad1fda Add a QA check on some base libraries (for now only libedit and libarchive) 2015-07-19 22:07:13 +00:00
Dmitry Marakasov
e42d0cc9db - Add /usr/sbin/dtrace to the list of allowed shebangs
Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D3070
2015-07-14 20:36:01 +00:00
Ryan Steinmetz
041a8dd21d - Provide a check/warning/fix for users that upgraded from an older release and missed UPDATING 20150213
Approved by:	portmgr (bapt)
2015-07-07 06:03:35 +00:00
Baptiste Daroussin
0c54521b1a Rewite CLEAN-DEPENDS*
Move inlined shell code into a proper script taking 2 args in arguments: full or
limited. The code I more simpler and understandable. The argument allows to
factorize the code between CLEAN-DEPENDS-FULL and CLEAN-DEPENDS-LIST

While here, make the code accept dependencies without ${PORTSDIR}
2015-07-04 08:56:54 +00:00
Baptiste Daroussin
57e67943aa Fix missing variable that got accidentally removed before commit 2015-07-01 21:08:42 +00:00
Baptiste Daroussin
c389e6d809 Move all-depends-list to a regular script
The benefice beside being more readable is to allow support for dependency line
without ${PORTSDIR}

This is also necessary to be able to easily hack on it for FLAVORS/SUBPACKAGE
support
2015-07-01 20:27:19 +00:00
Baptiste Daroussin
65dcc9c127 Factorize the function to validate env
Reviewed by:	antoine
Differential Revision:	https://reviews.freebsd.org/D2966
2015-07-01 20:08:26 +00:00
Steve Wills
ece696bef0 Remove disconnected script 2015-07-01 15:26:41 +00:00
Baptiste Daroussin
ab8c1339c4 Add PATH environment when trying to find libraries this fixes building under
qemu emulation

Reported by:	Sylvain Garrigues (via #poudriere)
Tested by:	Sylvain Garrigues (via #poudriere)
2015-06-30 19:54:23 +00:00
Baptiste Daroussin
a974ccd864 Refactor dependency checks and installation
This is an important step to prepare the ports tree for VARIANTS(aka flavours)
and subpackage by making the dependency code easier to deal with.

Change:
- Externalize in a proper shell script the code that was an inlined shell script
- Add better validation on the syntaxe used
- test after the dependency has been installed that it actually really fulfill
  the pattern searched (improving QA)
- Unify lib-depends with other dependency checks
- Make ${PORTSDIR} not mandatory anymore in _DEPENDS lines:
  aka pattern:${PORTSDIR}/category/port can now be written pattern:category/port
  /!\ Please to not use this syntax yet! poudriere have received a fix to be
  able to handle this new syntax (but no new release of poudriere has it yet)
  portmaster/portupgrade hasn't been checked. if one cares about those last 2 it
  would be really nice to provide patches to them!
- Remove _DEPENDS_ALWAYS it has half broken for a while and did not really make
  sense.
- Keep STRICT_DEPENDS for now it might not be necessary anymore given all the
  new checks added, but until someone confirms it is worth keeping it.

Note that all the env passed are prefixed by 'dp_' to avoid polluting children
make

Differential Revision:	https://reviews.freebsd.org/D2897
Reviewed by:	antoine
Exp-run by:	antoine
2015-06-28 18:50:37 +00:00
Dmitry Marakasov
103d62fa7a - Add blacklist of files which are not intended to be executed to shebang test
- Sort shebang list

Differential Revision:	D2670
Submitted by:	amdmi3
Approved by:	portmgr (bapt)
2015-06-04 11:37:13 +00:00
Dmitry Marakasov
d4848777d3 - Add ${PREFIX}/www to shebang check. We have many shebang problems which need to be discovered and fixed in www category.
Differential Revision:	D2580
Approved by:	portmgr (bapt)
2015-05-20 19:47:51 +00:00
Bryan Drewery
d200dc8283 Fix strip check to consider setuid binaries.
file(1) returns 'setuid' before the rest of the ELF output.

With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-04-30 02:44:30 +00:00
Tijl Coosemans
68edbeeaae - Display a stage-qa warning when ports use PREFIX/var instead of /var
- Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not
  when CONFIGURE_ARGS already sets it.  (GNU configure scripts set it to
  PREFIX/var when PREFIX != /usr.)
- Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so
  they aren't affected by this change (for now at least).  This commit is
  meant to ensure that new ports don't make the same mistake.

- games/acm: the configure script in this port is very old; instead of
  patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE.
- irc/charybdis: it already used /var but adding --localstatedir=/var
  changed the behaviour of the configure script; adjust the port to this.

PR:		199506
Exp-run by:	antoine
Approved by:	portmgr (antoine)
2015-04-20 19:06:29 +00:00
Antoine Brodin
a417c432e5 - Remove dead function from find-lib.sh
- Print a message if dependency registration on a package failed

With hat:	portmgr
2015-04-10 08:45:09 +00:00
Baptiste Daroussin
15da689cce Remove unintended change from r383627 2015-04-09 07:50:52 +00:00
Baptiste Daroussin
39cad29a6e Remove USE_GNUSTEP from bsd.port.mk 2015-04-09 07:49:34 +00:00
Baptiste Daroussin
a77d7def34 Stop trying to resolv symlinks when looking up for a shlib
file -L is resolving them properly and actual-package-depends.sh is also
correctly resolving them

Exp-run by:	antoine
2015-04-09 06:36:01 +00:00
Mark Felder
f582bb666a Speed up checking for stripped binaries
Skip ascii files. This significantly speeds up stage-qa on ports with a
considerable amount of text files being installed.

Differential Revision:	https://reviews.freebsd.org/D2121
Approved by:	bdrewery
2015-03-23 20:41:13 +00:00
Baptiste Daroussin
a5da770e67 Make fonts repecting XDG
Xorg is now looking in ${LOCALBASE}/share/fonts by default
Xorg now accepts symlinks in etc/X11/fontpath.d (as decribed in Xserver(1))
Large cleanup on lots of font ports
All fonts are now properly dynamically generating fonts.dir and fonts.scale
instead of sometime overwriting existing ones)
All fonts are generating fontconfig's cache
Improve consistency in fonts ports
2015-03-21 23:05:19 +00:00
Antoine Brodin
c977e8cc17 Remove a debug line from actual-package-depends
With hat:	portmgr
2015-03-11 22:08:31 +00:00
Baptiste Daroussin
90dc66b285 Rework dependency registration
Change the way the dependencies are registred so that now it follows the same
mechanism as when the *_DEPENDS making the dependency registration system ready
to allow multiple packages from the same origin such as flavours and subpackages

Also allowing to install twice the same port one built with python33 and the
other built with python27 for example.

PR:		19702
With help of:	antoine
Exp-run:	portmgr (antoine)
2015-02-09 17:16:43 +00:00
Bryan Drewery
531f0016ec Don't replace PREFIX anywhere in the plist line, only do it for the beginning.
With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-01-22 21:05:51 +00:00
Bryan Drewery
de0b44a025 - Move parse_plist() into a new file, functions.sh.
With hat:	portmgr
2015-01-08 04:04:55 +00:00
Bryan Drewery
50c51ed0af - Rework check on $makeplist in parse_plist(). The variable was/is always 0 as
the makeplist code does not use parse_plist(). Rename the param to
  'parse_comments' to be more clear on what it is for. This is kept for
  upcoming refactoring.

With hat:	portmgr
2015-01-08 03:55:00 +00:00
Bryan Drewery
58a64b69a3 Limit the scope of variables in parse_plist()
With hat:	portmgr
2015-01-08 03:37:20 +00:00