Commit graph

95 commits

Author SHA1 Message Date
Dmitry Marakasov
d4848777d3 - Add ${PREFIX}/www to shebang check. We have many shebang problems which need to be discovered and fixed in www category.
Differential Revision:	D2580
Approved by:	portmgr (bapt)
2015-05-20 19:47:51 +00:00
Bryan Drewery
d200dc8283 Fix strip check to consider setuid binaries.
file(1) returns 'setuid' before the rest of the ELF output.

With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-04-30 02:44:30 +00:00
Tijl Coosemans
68edbeeaae - Display a stage-qa warning when ports use PREFIX/var instead of /var
- Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not
  when CONFIGURE_ARGS already sets it.  (GNU configure scripts set it to
  PREFIX/var when PREFIX != /usr.)
- Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so
  they aren't affected by this change (for now at least).  This commit is
  meant to ensure that new ports don't make the same mistake.

- games/acm: the configure script in this port is very old; instead of
  patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE.
- irc/charybdis: it already used /var but adding --localstatedir=/var
  changed the behaviour of the configure script; adjust the port to this.

PR:		199506
Exp-run by:	antoine
Approved by:	portmgr (antoine)
2015-04-20 19:06:29 +00:00
Antoine Brodin
a417c432e5 - Remove dead function from find-lib.sh
- Print a message if dependency registration on a package failed

With hat:	portmgr
2015-04-10 08:45:09 +00:00
Baptiste Daroussin
15da689cce Remove unintended change from r383627 2015-04-09 07:50:52 +00:00
Baptiste Daroussin
39cad29a6e Remove USE_GNUSTEP from bsd.port.mk 2015-04-09 07:49:34 +00:00
Baptiste Daroussin
a77d7def34 Stop trying to resolv symlinks when looking up for a shlib
file -L is resolving them properly and actual-package-depends.sh is also
correctly resolving them

Exp-run by:	antoine
2015-04-09 06:36:01 +00:00
Mark Felder
f582bb666a Speed up checking for stripped binaries
Skip ascii files. This significantly speeds up stage-qa on ports with a
considerable amount of text files being installed.

Differential Revision:	https://reviews.freebsd.org/D2121
Approved by:	bdrewery
2015-03-23 20:41:13 +00:00
Baptiste Daroussin
a5da770e67 Make fonts repecting XDG
Xorg is now looking in ${LOCALBASE}/share/fonts by default
Xorg now accepts symlinks in etc/X11/fontpath.d (as decribed in Xserver(1))
Large cleanup on lots of font ports
All fonts are now properly dynamically generating fonts.dir and fonts.scale
instead of sometime overwriting existing ones)
All fonts are generating fontconfig's cache
Improve consistency in fonts ports
2015-03-21 23:05:19 +00:00
Antoine Brodin
c977e8cc17 Remove a debug line from actual-package-depends
With hat:	portmgr
2015-03-11 22:08:31 +00:00
Baptiste Daroussin
90dc66b285 Rework dependency registration
Change the way the dependencies are registred so that now it follows the same
mechanism as when the *_DEPENDS making the dependency registration system ready
to allow multiple packages from the same origin such as flavours and subpackages

Also allowing to install twice the same port one built with python33 and the
other built with python27 for example.

PR:		19702
With help of:	antoine
Exp-run:	portmgr (antoine)
2015-02-09 17:16:43 +00:00
Bryan Drewery
531f0016ec Don't replace PREFIX anywhere in the plist line, only do it for the beginning.
With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-01-22 21:05:51 +00:00
Bryan Drewery
de0b44a025 - Move parse_plist() into a new file, functions.sh.
With hat:	portmgr
2015-01-08 04:04:55 +00:00
Bryan Drewery
50c51ed0af - Rework check on $makeplist in parse_plist(). The variable was/is always 0 as
the makeplist code does not use parse_plist(). Rename the param to
  'parse_comments' to be more clear on what it is for. This is kept for
  upcoming refactoring.

With hat:	portmgr
2015-01-08 03:55:00 +00:00
Bryan Drewery
58a64b69a3 Limit the scope of variables in parse_plist()
With hat:	portmgr
2015-01-08 03:37:20 +00:00
Baptiste Daroussin
fc3d3dcbe9 Remove now useless gnomehier, pkg handles automatically the directories where
needed making gnomehier entirely useless now.

Differential Revision:	https://reviews.freebsd.org/D1355
Reviewed by:	antoine, kwm
Approved by:	gnome (kwm)
2014-12-25 01:10:19 +00:00
Antoine Brodin
cf0b040a44 - Add three empty dirs that belonged to gnomehier to devel/gconf2,
this prevents stage violations during build of ports using gconftool-2
- White list etc/gconf/gconf.xml.defaults from stage orphans as gconftool-2
  is unpredictable

With hat:	portmgr
2014-12-23 13:47:10 +00:00
Mathieu Arnold
bc0be6ac56 Don't output a warning if PERL_ARCH does not exist.
With hat:	portmgr
Sponsored by:	Absolight
2014-12-23 00:27:18 +00:00
Mathieu Arnold
64835f0cdc Make Perl link all .so it builds with libperl.so.
It makes upgrading from one Perl major version to another way easier.  For
binary package users, it means pkg upgrade will detect the libperl.so.x.yy
change, and reinstall the affected packages.  For users using ports, it will
save rebuild time as it's easier to detect what ports really need to be
rebuilt.

PR:		195821
Differential Revision: https://reviews.freebsd.org/D1241
Submitted by:	mat
Reviewed by:	antoine, bdrewery
Exp-run by:	antoine
With hat:	perl
Sponsored by:	Absolight
2014-12-17 13:21:56 +00:00
Antoine Brodin
525472b249 Fix a false positive home directory leftover for ports with multiple USERS
or with USERS matching another user in UIDs

Reported by:	adamw (mail/spamassassin)
With hat:	portmgr
2014-12-01 17:57:19 +00:00
Antoine Brodin
fd76fd9625 - During makeplist, emit only empty directories inside prefix and
directories outside prefix
- Whitelisting orphan directories not starting with / is no longer necessary
- Adjust missing directories check to use a list of all directories instead
  of the dirs from make-plist

Differential Revision:	https://reviews.freebsd.org/D1101
Reviewed by:	bapt
With hat:	portmgr
2014-11-05 07:14:21 +00:00
Alex Kozlov
6107ede2ac - Accept absolute path for @fc, @fontsdir, @fcfontsdir, @shell keywords
Approved by:	portmgr (antoine, bapt)
Differential Revision:	https://reviews.freebsd.org/D721
2014-10-08 21:39:47 +00:00
Antoine Brodin
df3c805917 info keyword now handles full paths
With hat:	portmgr
2014-10-08 06:19:54 +00:00
Antoine Brodin
82646f1abd Replace @dirrm/@dirrmtry with @dir in makeplist and leftovers check
Differential Revision:	https://reviews.freebsd.org/D901
Reviewed by:	bapt
With hat:	portmgr
2014-10-06 19:17:22 +00:00
Bryan Drewery
32852abae0 - Allow LINUXBASE for shebangs.
PR:		193878
Submitted by:	Jan Beich <jbeich@vfemail.net>
With hat:	portmgr
2014-10-03 18:47:47 +00:00
Bryan Drewery
63fc9a3edb check-plist no longer needs to check for directories owned by dependencies.
pkg-1.3.8's auto directory handling makes this a non-issue.

We should add a new check to warn of possibly needing @dir for empty dirs
though.

With hat:	portmgr
2014-10-03 18:22:46 +00:00
Bryan Drewery
36716bd31e Garbage collect dependency mtree check removed in r368803 2014-10-03 18:14:18 +00:00
Antoine Brodin
68bcf28124 Do not report directories in plist as orphans
With hat:	portmgr
2014-09-22 07:53:57 +00:00
Baptiste Daroussin
cdc718adfc adjust check_stagedir.sh to take in account %%KEY%%@dirrm* 2014-09-22 06:22:56 +00:00
Baptiste Daroussin
6423d85837 Update to 1.3.8 Changes:
- Plist parser do not accept modes like o+w g+s u+r
- @owner/@group with no argument reset the default ownership to root/wheel
- Plug regression tests into the release mechanism as mandatory
- Allow url in repository configuration to be overriden by another configuration
  file
- If one of -P, -I or -R is not explicitly given on the command line do not emit
  error messages while searching for a mechanism to find data about the latest
  available ports.
- External keywords can now take arguments
- Directories under PREFIX are automatically handled and removed if needed
- MTREE are not packaged anymore neither extracted on final installation
- OS major checking (to determine if pkg is running on an upgraded base system)
  uses the same mechanism as ABI detection instead of relying on UNAME_r which
  can have false positivie on jails
- Add @dir keyword for plist which is used to package explicitly directories
  (directories with non root/wheel or outside prefix) and empty directories
  (@dirrm and @dirrmtry are now considered as deprecated)
- root/wheel are now considered as the default user/group when creating a
  package except @owner/@group are used to change that behaviour
- Import newer version of libucl which improves error messages in case of
  problem parsing manifest or configuration files
- Fix pkg register so it checks for conflicts before actually copying files on
  to the filesystem
- pkg now support a new no_provide_lib annotation to preventing automatic
  populating of provided libs (useful for packages bundling libraries like wine)
- Improve documentations
- Ability to select usage of IPv4/IPv6 via config, repository config or command
  line
- Lots of bug fixes

Side effects:
- Convert to install-mtree target into a no-op target Add empty directories to
  plist of ports that needs them to run:
- share/aclocal to devel/automake and devel/automake14
- share/applications to devel/desktop-file-utils
- share/xml share/sgml to textproc/xmlcatmgr
- Prevent check-plist to issue warnings about some @dir*
- Adjist check_leftovers.sh to not take in account anything related to mtree
- Bump the default required version of pkg to 1.3.8
2014-09-22 05:47:32 +00:00
Antoine Brodin
8c8d939697 Fix typo
With hat:	portmgr
2014-09-17 19:02:59 +00:00
Tijl Coosemans
fad34ea21f Turn the installation of *.la files, without some form of USES=libtool in
the port Makefile, into a stage-qa error.  All ports that would trigger
this error have been converted.  Many thanks to all people involved in
this, especially Dmitry Marakasov (amdmi3) who handled most ports.

At this moment over 2200 ports have USES=libtool and over 20000 library
dependencies between packages have been removed.

This also marks the point where :keepla is no longer special.  It is now
only needed if a port uses *.la files at run-time.

QA-run by:	antoine
Approved by:	portmgr (antoine)
2014-09-15 18:23:21 +00:00
Antoine Brodin
fbcb1bc222 Make check-stagedir.sh aware of (owner,group,perm) syntax for keywords
Differential Revision:	https://reviews.freebsd.org/D712
Reviewed by:	bapt
With hat:	portmgr
2014-09-02 14:36:29 +00:00
Antoine Brodin
26222800aa - Make it possible to use sample keyword with a full path
- Prefer @dirrmtry over @unexec rmdir in makeplist

Differential Revision:	https://reviews.freebsd.org/D705
Reviewed by:	bapt
With hat:	portmgr
2014-09-01 17:06:19 +00:00
Baptiste Daroussin
d96aa38d95 Remove support for pkg_install
Merge back bsd.pkgng.mk into bsd.port.mk
Add a note about @stopdaemon not being supported anymore

With hat:	portmgr
Differential Revision:	https://reviews.freebsd.org/D693
2014-09-01 13:03:25 +00:00
Antoine Brodin
8ffd5fe7a8 Ignore references to stagedir in .fmt and .log files generated for tex formats
Those are harmless (records from which file they were generated from) and
removing them would require ugly hacks according to hrs@

PR:		ports/192933
Differential Revision:	https://reviews.freebsd.org/D684
Reviewed by:	bapt, hrs
With hat:	portmgr
2014-08-30 08:55:57 +00:00
Antoine Brodin
4d04df1859 Check that the plist doesn't reference the stage dir during stage-qa
====> Running Q/A tests (stage-qa)
Error: '/usr/ports/www/claroline/work/.PLIST.mktmp' is referring to /usr/ports/www/claroline/work/stage
*** Error code 1

Differential Revision: https://reviews.freebsd.org/D685
Reviewed by:	bdrewery
With hat:	portmgr
2014-08-25 22:10:42 +00:00
Bryan Drewery
3777dc8252 - Add the same workaround for ignoring PREFIX/info removal when PREFIX !=
LOCALBASE, as check-stagedir has.

With hat:	portmgr
2014-08-19 14:36:49 +00:00
Antoine Brodin
4451bbef17 Advise trying INSTALL_TARGET=install-strip before ${STRIP_CMD}
Phabric:	D477
Reviewed by:	bdrewery
With hat:	portmgr
2014-08-17 17:48:26 +00:00
Bryan Drewery
759281b0d7 - Fix 'make check-plist' incorrectly considering all installed packages as
run dependencies if the port being checked has no RUN_DEPENDS. This could
  cause false-positive "Possibly owned by dependency" warnings.

With hat:	portmgr
2014-08-11 20:20:23 +00:00
Bryan Drewery
deff4ba4c7 - Fix check-plist so that its 'files in plist but missing from STAGEDIR' check
does not incorrectly ignore plist items in %%DOCSDIR%% and %%EXAMPLESDIR%%.
  It was incorrectly ignoring these items when %%PORTDOCS%% or %%PORTEXAMPLES%%
  was missing. This manifested as a failure in 'make package' later when pkg(8)
  detected the missing files.

With hat:	portmgr
2014-07-24 21:03:10 +00:00
Antoine Brodin
57abe3e15a Do not report parent directories of LOCALBASE as orphans
Reported and tested by:	gerald
With hat:	portmgr
2014-06-30 22:26:51 +00:00
Antoine Brodin
b06fe94540 Do not report files @commented by multiple options as orphans
With hat:	portmgr
2014-06-20 21:07:30 +00:00
Rene Ladan
3143a73f6d Mk/Scripts/qa.sh: add /bin/tcsh as a valid shebang.
Phabric:	D231
Approved by:	portmgr (antoine)
2014-06-17 14:33:53 +00:00
Daichi GOTO
af01be4cba fix a typo 2014-06-13 10:30:45 +00:00
Baptiste Daroussin
2bacde9c3b Add an @shell keyword to handle adding and remove a shell path in /etc/shell
Bump port revision of all ports that were doing it wrong prior to the keyword

CR:		D208
Reviewed by:	antoine
With hat:	portmgr
2014-06-11 17:42:36 +00:00
Antoine Brodin
4c05fc29da Add more files to orphans white list:
- .DS_Store files
- some VCS related files

Note: it's still recommended to not extract/install those files if they are
not needed

PR:		ports/189859
Submitted by:	adamw (first version)
Reviewed by:	bapt
With hat:	portmgr
2014-05-19 16:09:00 +00:00
Bryan Drewery
e380c31a46 - %D is based on @cwd, not PREFIX; Fix false-postives when using pkg_install
and @cwd has changed away from PREFIX:

    plist:
      @cwd /
      @dirrmtry var/spool/dma

    ====> Checking for pkg-plist issues (check-plist)
    ===> Parsing plist
    DIR '/usr/local/etc/dma' CWD: /usr/local
    DIR '/usr/local/var/spool/dma' CWD:
    DIR 'share/licenses/dma-v0.9,1' CWD: /usr/local
    DIR '/usr/local/share/licenses' CWD: /usr/local
    ===> Checking for items in STAGEDIR missing from pkg-plist
    Error: Orphaned: @unexec rmdir "/var/spool/dma" >/dev/null 2>&1 || :
    ===> Checking for directories owned by MTREEs
    ===> Checking for directories handled by dependencies
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    Error: Missing: @dirrmtry var/spool/dma
    ===> Error: Plist issues found.

With hat:	portmgr
Reported by:	erwin
2014-05-18 01:51:43 +00:00
Bryan Drewery
2387ec96ea - Fix check-plist showing @sample dest files as orphans and also showing in
makeplist.

Reported by:	droso
With hat:	portmgr
2014-05-16 17:21:44 +00:00
Bryan Drewery
94ec4229c2 - Move security-check.awk to Mk/Scripts where it is more proper these days.
With hat:	portmgr
2014-05-09 22:35:50 +00:00