Commit graph

112 commits

Author SHA1 Message Date
Antoine Brodin
cfff850167 Make baselibs QA check non recursive and activate it again
Reviewed by:	bapt
Differential Revision:	https://reviews.freebsd.org/D3352
2015-08-10 17:06:50 +00:00
Baptiste Daroussin
f575dbf44e Disable baselibs check until it is made saner (aka non recursive) 2015-08-09 11:41:56 +00:00
Antoine Brodin
b11b1637e0 Fix a typo that made baselibs QA check run twice on some files
With hat:	portmgr
2015-08-09 10:10:03 +00:00
Fukang Chen
d5ee3ef661 checks $WRKSRC for all direct dependencies in the limited-clean-depends:
target, like the original CLEAN-DEPENDS-LIMITED in bsd.port.mk

Approved by: bapt
Differential Revision: https://reviews.freebsd.org/D3233
2015-07-30 07:43:49 +00:00
Mathieu Arnold
f08b36d14d Split LIB_DEPENDS and the other _DEPENDS types.
Reviewed by:	bapt, pgolluci
Exp-run by:	mat
Approved by:	bapt
With hat:	portmgr
Sponsored by:	Absolight
Differential Revision:	https://reviews.freebsd.org/D3150
2015-07-24 10:11:18 +00:00
Baptiste Daroussin
7b41fe4853 Fix path of libedit 2015-07-19 22:19:37 +00:00
Baptiste Daroussin
81e9ad1fda Add a QA check on some base libraries (for now only libedit and libarchive) 2015-07-19 22:07:13 +00:00
Dmitry Marakasov
e42d0cc9db - Add /usr/sbin/dtrace to the list of allowed shebangs
Submitted by:	amdmi3
Approved by:	portmgr (bapt)
Differential Revision:	D3070
2015-07-14 20:36:01 +00:00
Ryan Steinmetz
041a8dd21d - Provide a check/warning/fix for users that upgraded from an older release and missed UPDATING 20150213
Approved by:	portmgr (bapt)
2015-07-07 06:03:35 +00:00
Baptiste Daroussin
0c54521b1a Rewite CLEAN-DEPENDS*
Move inlined shell code into a proper script taking 2 args in arguments: full or
limited. The code I more simpler and understandable. The argument allows to
factorize the code between CLEAN-DEPENDS-FULL and CLEAN-DEPENDS-LIST

While here, make the code accept dependencies without ${PORTSDIR}
2015-07-04 08:56:54 +00:00
Baptiste Daroussin
57e67943aa Fix missing variable that got accidentally removed before commit 2015-07-01 21:08:42 +00:00
Baptiste Daroussin
c389e6d809 Move all-depends-list to a regular script
The benefice beside being more readable is to allow support for dependency line
without ${PORTSDIR}

This is also necessary to be able to easily hack on it for FLAVORS/SUBPACKAGE
support
2015-07-01 20:27:19 +00:00
Baptiste Daroussin
65dcc9c127 Factorize the function to validate env
Reviewed by:	antoine
Differential Revision:	https://reviews.freebsd.org/D2966
2015-07-01 20:08:26 +00:00
Steve Wills
ece696bef0 Remove disconnected script 2015-07-01 15:26:41 +00:00
Baptiste Daroussin
ab8c1339c4 Add PATH environment when trying to find libraries this fixes building under
qemu emulation

Reported by:	Sylvain Garrigues (via #poudriere)
Tested by:	Sylvain Garrigues (via #poudriere)
2015-06-30 19:54:23 +00:00
Baptiste Daroussin
a974ccd864 Refactor dependency checks and installation
This is an important step to prepare the ports tree for VARIANTS(aka flavours)
and subpackage by making the dependency code easier to deal with.

Change:
- Externalize in a proper shell script the code that was an inlined shell script
- Add better validation on the syntaxe used
- test after the dependency has been installed that it actually really fulfill
  the pattern searched (improving QA)
- Unify lib-depends with other dependency checks
- Make ${PORTSDIR} not mandatory anymore in _DEPENDS lines:
  aka pattern:${PORTSDIR}/category/port can now be written pattern:category/port
  /!\ Please to not use this syntax yet! poudriere have received a fix to be
  able to handle this new syntax (but no new release of poudriere has it yet)
  portmaster/portupgrade hasn't been checked. if one cares about those last 2 it
  would be really nice to provide patches to them!
- Remove _DEPENDS_ALWAYS it has half broken for a while and did not really make
  sense.
- Keep STRICT_DEPENDS for now it might not be necessary anymore given all the
  new checks added, but until someone confirms it is worth keeping it.

Note that all the env passed are prefixed by 'dp_' to avoid polluting children
make

Differential Revision:	https://reviews.freebsd.org/D2897
Reviewed by:	antoine
Exp-run by:	antoine
2015-06-28 18:50:37 +00:00
Dmitry Marakasov
103d62fa7a - Add blacklist of files which are not intended to be executed to shebang test
- Sort shebang list

Differential Revision:	D2670
Submitted by:	amdmi3
Approved by:	portmgr (bapt)
2015-06-04 11:37:13 +00:00
Dmitry Marakasov
d4848777d3 - Add ${PREFIX}/www to shebang check. We have many shebang problems which need to be discovered and fixed in www category.
Differential Revision:	D2580
Approved by:	portmgr (bapt)
2015-05-20 19:47:51 +00:00
Bryan Drewery
d200dc8283 Fix strip check to consider setuid binaries.
file(1) returns 'setuid' before the rest of the ELF output.

With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-04-30 02:44:30 +00:00
Tijl Coosemans
68edbeeaae - Display a stage-qa warning when ports use PREFIX/var instead of /var
- Add --localstatedir=/var to _LATE_CONFIGURE_ARGS (like --mandir) but not
  when CONFIGURE_ARGS already sets it.  (GNU configure scripts set it to
  PREFIX/var when PREFIX != /usr.)
- Add --localstatedir="${PREFIX}/var" to CONFIGURE_ARGS in some ports so
  they aren't affected by this change (for now at least).  This commit is
  meant to ensure that new ports don't make the same mistake.

- games/acm: the configure script in this port is very old; instead of
  patching it more, just replace GNU_CONFIGURE with HAS_CONFIGURE.
- irc/charybdis: it already used /var but adding --localstatedir=/var
  changed the behaviour of the configure script; adjust the port to this.

PR:		199506
Exp-run by:	antoine
Approved by:	portmgr (antoine)
2015-04-20 19:06:29 +00:00
Antoine Brodin
a417c432e5 - Remove dead function from find-lib.sh
- Print a message if dependency registration on a package failed

With hat:	portmgr
2015-04-10 08:45:09 +00:00
Baptiste Daroussin
15da689cce Remove unintended change from r383627 2015-04-09 07:50:52 +00:00
Baptiste Daroussin
39cad29a6e Remove USE_GNUSTEP from bsd.port.mk 2015-04-09 07:49:34 +00:00
Baptiste Daroussin
a77d7def34 Stop trying to resolv symlinks when looking up for a shlib
file -L is resolving them properly and actual-package-depends.sh is also
correctly resolving them

Exp-run by:	antoine
2015-04-09 06:36:01 +00:00
Mark Felder
f582bb666a Speed up checking for stripped binaries
Skip ascii files. This significantly speeds up stage-qa on ports with a
considerable amount of text files being installed.

Differential Revision:	https://reviews.freebsd.org/D2121
Approved by:	bdrewery
2015-03-23 20:41:13 +00:00
Baptiste Daroussin
a5da770e67 Make fonts repecting XDG
Xorg is now looking in ${LOCALBASE}/share/fonts by default
Xorg now accepts symlinks in etc/X11/fontpath.d (as decribed in Xserver(1))
Large cleanup on lots of font ports
All fonts are now properly dynamically generating fonts.dir and fonts.scale
instead of sometime overwriting existing ones)
All fonts are generating fontconfig's cache
Improve consistency in fonts ports
2015-03-21 23:05:19 +00:00
Antoine Brodin
c977e8cc17 Remove a debug line from actual-package-depends
With hat:	portmgr
2015-03-11 22:08:31 +00:00
Baptiste Daroussin
90dc66b285 Rework dependency registration
Change the way the dependencies are registred so that now it follows the same
mechanism as when the *_DEPENDS making the dependency registration system ready
to allow multiple packages from the same origin such as flavours and subpackages

Also allowing to install twice the same port one built with python33 and the
other built with python27 for example.

PR:		19702
With help of:	antoine
Exp-run:	portmgr (antoine)
2015-02-09 17:16:43 +00:00
Bryan Drewery
531f0016ec Don't replace PREFIX anywhere in the plist line, only do it for the beginning.
With hat:	portmgr
Sponsored by:	EMC / Isilon Storage Division
2015-01-22 21:05:51 +00:00
Bryan Drewery
de0b44a025 - Move parse_plist() into a new file, functions.sh.
With hat:	portmgr
2015-01-08 04:04:55 +00:00
Bryan Drewery
50c51ed0af - Rework check on $makeplist in parse_plist(). The variable was/is always 0 as
the makeplist code does not use parse_plist(). Rename the param to
  'parse_comments' to be more clear on what it is for. This is kept for
  upcoming refactoring.

With hat:	portmgr
2015-01-08 03:55:00 +00:00
Bryan Drewery
58a64b69a3 Limit the scope of variables in parse_plist()
With hat:	portmgr
2015-01-08 03:37:20 +00:00
Baptiste Daroussin
fc3d3dcbe9 Remove now useless gnomehier, pkg handles automatically the directories where
needed making gnomehier entirely useless now.

Differential Revision:	https://reviews.freebsd.org/D1355
Reviewed by:	antoine, kwm
Approved by:	gnome (kwm)
2014-12-25 01:10:19 +00:00
Antoine Brodin
cf0b040a44 - Add three empty dirs that belonged to gnomehier to devel/gconf2,
this prevents stage violations during build of ports using gconftool-2
- White list etc/gconf/gconf.xml.defaults from stage orphans as gconftool-2
  is unpredictable

With hat:	portmgr
2014-12-23 13:47:10 +00:00
Mathieu Arnold
bc0be6ac56 Don't output a warning if PERL_ARCH does not exist.
With hat:	portmgr
Sponsored by:	Absolight
2014-12-23 00:27:18 +00:00
Mathieu Arnold
64835f0cdc Make Perl link all .so it builds with libperl.so.
It makes upgrading from one Perl major version to another way easier.  For
binary package users, it means pkg upgrade will detect the libperl.so.x.yy
change, and reinstall the affected packages.  For users using ports, it will
save rebuild time as it's easier to detect what ports really need to be
rebuilt.

PR:		195821
Differential Revision: https://reviews.freebsd.org/D1241
Submitted by:	mat
Reviewed by:	antoine, bdrewery
Exp-run by:	antoine
With hat:	perl
Sponsored by:	Absolight
2014-12-17 13:21:56 +00:00
Antoine Brodin
525472b249 Fix a false positive home directory leftover for ports with multiple USERS
or with USERS matching another user in UIDs

Reported by:	adamw (mail/spamassassin)
With hat:	portmgr
2014-12-01 17:57:19 +00:00
Antoine Brodin
fd76fd9625 - During makeplist, emit only empty directories inside prefix and
directories outside prefix
- Whitelisting orphan directories not starting with / is no longer necessary
- Adjust missing directories check to use a list of all directories instead
  of the dirs from make-plist

Differential Revision:	https://reviews.freebsd.org/D1101
Reviewed by:	bapt
With hat:	portmgr
2014-11-05 07:14:21 +00:00
Alex Kozlov
6107ede2ac - Accept absolute path for @fc, @fontsdir, @fcfontsdir, @shell keywords
Approved by:	portmgr (antoine, bapt)
Differential Revision:	https://reviews.freebsd.org/D721
2014-10-08 21:39:47 +00:00
Antoine Brodin
df3c805917 info keyword now handles full paths
With hat:	portmgr
2014-10-08 06:19:54 +00:00
Antoine Brodin
82646f1abd Replace @dirrm/@dirrmtry with @dir in makeplist and leftovers check
Differential Revision:	https://reviews.freebsd.org/D901
Reviewed by:	bapt
With hat:	portmgr
2014-10-06 19:17:22 +00:00
Bryan Drewery
32852abae0 - Allow LINUXBASE for shebangs.
PR:		193878
Submitted by:	Jan Beich <jbeich@vfemail.net>
With hat:	portmgr
2014-10-03 18:47:47 +00:00
Bryan Drewery
63fc9a3edb check-plist no longer needs to check for directories owned by dependencies.
pkg-1.3.8's auto directory handling makes this a non-issue.

We should add a new check to warn of possibly needing @dir for empty dirs
though.

With hat:	portmgr
2014-10-03 18:22:46 +00:00
Bryan Drewery
36716bd31e Garbage collect dependency mtree check removed in r368803 2014-10-03 18:14:18 +00:00
Antoine Brodin
68bcf28124 Do not report directories in plist as orphans
With hat:	portmgr
2014-09-22 07:53:57 +00:00
Baptiste Daroussin
cdc718adfc adjust check_stagedir.sh to take in account %%KEY%%@dirrm* 2014-09-22 06:22:56 +00:00
Baptiste Daroussin
6423d85837 Update to 1.3.8 Changes:
- Plist parser do not accept modes like o+w g+s u+r
- @owner/@group with no argument reset the default ownership to root/wheel
- Plug regression tests into the release mechanism as mandatory
- Allow url in repository configuration to be overriden by another configuration
  file
- If one of -P, -I or -R is not explicitly given on the command line do not emit
  error messages while searching for a mechanism to find data about the latest
  available ports.
- External keywords can now take arguments
- Directories under PREFIX are automatically handled and removed if needed
- MTREE are not packaged anymore neither extracted on final installation
- OS major checking (to determine if pkg is running on an upgraded base system)
  uses the same mechanism as ABI detection instead of relying on UNAME_r which
  can have false positivie on jails
- Add @dir keyword for plist which is used to package explicitly directories
  (directories with non root/wheel or outside prefix) and empty directories
  (@dirrm and @dirrmtry are now considered as deprecated)
- root/wheel are now considered as the default user/group when creating a
  package except @owner/@group are used to change that behaviour
- Import newer version of libucl which improves error messages in case of
  problem parsing manifest or configuration files
- Fix pkg register so it checks for conflicts before actually copying files on
  to the filesystem
- pkg now support a new no_provide_lib annotation to preventing automatic
  populating of provided libs (useful for packages bundling libraries like wine)
- Improve documentations
- Ability to select usage of IPv4/IPv6 via config, repository config or command
  line
- Lots of bug fixes

Side effects:
- Convert to install-mtree target into a no-op target Add empty directories to
  plist of ports that needs them to run:
- share/aclocal to devel/automake and devel/automake14
- share/applications to devel/desktop-file-utils
- share/xml share/sgml to textproc/xmlcatmgr
- Prevent check-plist to issue warnings about some @dir*
- Adjist check_leftovers.sh to not take in account anything related to mtree
- Bump the default required version of pkg to 1.3.8
2014-09-22 05:47:32 +00:00
Antoine Brodin
8c8d939697 Fix typo
With hat:	portmgr
2014-09-17 19:02:59 +00:00
Tijl Coosemans
fad34ea21f Turn the installation of *.la files, without some form of USES=libtool in
the port Makefile, into a stage-qa error.  All ports that would trigger
this error have been converted.  Many thanks to all people involved in
this, especially Dmitry Marakasov (amdmi3) who handled most ports.

At this moment over 2200 ports have USES=libtool and over 20000 library
dependencies between packages have been removed.

This also marks the point where :keepla is no longer special.  It is now
only needed if a port uses *.la files at run-time.

QA-run by:	antoine
Approved by:	portmgr (antoine)
2014-09-15 18:23:21 +00:00
Antoine Brodin
fbcb1bc222 Make check-stagedir.sh aware of (owner,group,perm) syntax for keywords
Differential Revision:	https://reviews.freebsd.org/D712
Reviewed by:	bapt
With hat:	portmgr
2014-09-02 14:36:29 +00:00