mykola/freebsd-ports
1
0
Fork 0
forked from Lainports/freebsd-ports
Code Pull requests Activity
freebsd-ports/lang/erlang-runtime21/Makefile
Dimitry Andric 9ce64e9190 lang/(erlang(-runtime2[13])?): work around dtrace failures with clang 13 
During an exp-run for llvm 13 (see bug 258209), it turned out that
lang/erlang and lang/erlang-runtime2[13] fail to build with clang 13.

What appears to happen is that for these versions of erlang, PGO is
enabled, and it first builds a PGO-enabled beam.smp:

gmake[5]: Entering directory '/wrkdirs/usr/ports/lang/erlang/work/otp-OTP-21.3.8.24/erts/emulator'
if utils/gen_git_version amd64-portbld-freebsd14.0/gen_git_version.mk; then touch beam/erl_bif_info.c; fi
echo " PROFILE beam.prof.smp"
 PROFILE beam.prof.smp
rm -f obj/amd64-portbld-freebsd14.0/opt/smp/erl*.profraw
set -e; LLVM_PROFILE_FILE="obj/amd64-portbld-freebsd14.0/opt/smp/erlc-%m.profraw" \
          ERL_FLAGS="-emu_type prof +S 1" erlc -W  -DPGO \
  -o obj/amd64-portbld-freebsd14.0/opt/smp test/estone_SUITE.erl > obj/amd64-portbld-freebsd14.0/opt/smp/PROFILE_LOG

after which it does a test run, and uses llvm-profdata to merge the
profiling data into beam_emu_pu.o:

  llvm-profdata merge -output obj/amd64-portbld-freebsd14.0/opt/smp/default.profdata obj/amd64-portbld-freebsd14.0/opt/smp/*.profraw
  cc -fprofile-instr-use=obj/amd64-portbld-freebsd14.0/opt/smp/default.profdata  -Werror=undef -Werror=implicit -Werror=return-type   -O3 -fomit-frame-pointer -pipe  -fno-omit-frame-pointer -DMAP_NORESERVE=0 -fstack-protector-strong -fno-strict-aliasing  -I/wrkdirs/usr/ports/lang/erlang/work/otp-OTP-21.3.8.24/erts/amd64-portbld-freebsd14.0    -DHAVE_CONFIG_H -Wall -Wstrict-prototypes -Wmissing-prototypes -Wdeclaration-after-statement -DUSE_THREADS -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS   -Iamd64-portbld-freebsd14.0/opt/smp -Ibeam -Isys/unix -Isys/common -Iamd64-portbld-freebsd14.0 -Ipcre -Ihipe -I../include -I../include/amd64-portbld-freebsd14.0 -I../include/internal -I../include/internal/amd64-portbld-freebsd14.0 -c beam/beam_emu.c -o obj/amd64-portbld-freebsd14.0/opt/smp/beam_emu_pu.o

Later, it runs dtrace over all the collected objects, and this dies:

  dtrace -G -C -Ibeam \
    -s beam/erlang_dtrace.d \
    -o obj/amd64-portbld-freebsd14.0/opt/smp/erlang_pu_dtrace.o
    ... long list of objects ...
  dtrace: failed to link script beam/erlang_dtrace.d: an error was encountered while processing obj/amd64-portbld-freebsd14.0/opt/smp/beam_emu_pu.o
  gmake[5]: *** [amd64-portbld-freebsd14.0/Makefile:1005: obj/amd64-portbld-freebsd14.0/opt/smp/erlang_pu_dtrace.o] Error 1
  gmake[5]: Leaving directory '/wrkdirs/usr/ports/lang/erlang/work/otp-OTP-21.3.8.24/erts/emulator'

Something in beam_emu_pu.o (emitted by clang or llvm 13) is tripping up
dtrace, but I have very little knowledge about dtrace so I need help
here. :)

Now some other erlang runtimes such as lang/erlang-runtime24 *do* build
successfully with clang 13, but this is only because upstream disabled
the PGO feature, as a side effect of
https://github.com/erlang/otp/commit/b165524c732 ("erts: Implement the
BeamAsm JIT"):

--- a/erts/configure.in
+++ b/erts/configure.in
...
@@ -704,6 +719,9 @@ else
   fi
 fi

+dnl Disable pgo for now
+USE_PGO=false
+
 AC_SUBST(USE_PGO)
 AC_SUBST(PROFILE_COMPILER)

I am unsure why upstream disabled this "for now", as it has been
disabled for more than a year. So, for now, work around the dtrace
failures by disabling PGO using the configure flag --disable-pgo, when
building with clang >= 13.

PR:		258494
Approved by:	maintainer timeout (2 weeks)
MFH:		2021Q4
2021-10-03 12:13:35 +02:00

168 lines
4.7 KiB
Makefile
Raw Blame History

# Created by: ruslan@shevchenko.kiev.ua
PORTNAME= erlang
DISTVERSIONPREFIX= OTP-
DISTVERSION= 21.3.8.24
PORTREVISION= 1
CATEGORIES= lang parallel java
PKGNAMESUFFIX= -runtime21
DIST_SUBDIR= erlang
MAINTAINER= erlang@FreeBSD.org
COMMENT= Functional programming language from Ericsson
LICENSE= APACHE20
BROKEN_sparc64= Fails to build: error: fp_except undeclared
USES= compiler autoreconf:build cpe gmake ncurses perl5
USE_GITHUB= nodefault
GH_ACCOUNT= erlang:otp,corba
GH_PROJECT= otp:otp corba:corba
GH_TAGNAME= 4.5.2:corba
USE_PERL5= build
CPE_VENDOR= erlang
CPE_PRODUCT= erlang/otp
GNU_CONFIGURE= yes
CONFIGURE_ARGS= --enable-smp-support
MAKE_JOBS_UNSAFE= yes
DATADIR= ${PREFIX}/share/${PORTNAME}${PKGNAMESUFFIX}
SUB_FILES= pkg-message
SUB_LIST= ERLANG_LIB=${ERLANG_LIB}
WRKSRC= ${WRKSRC_otp}
ERLANG_LIB= ${PORTNAME}${PORTVERSION:C/\..*//}
OPTIONS_DEFINE= CORBA DIRTY DTRACE HIPE JAVA KQUEUE NATIVE ODBC OPENSSL \
SCTP THREADS WX
OPTIONS_DEFAULT= CORBA DIRTY DTRACE HIPE KQUEUE OPENSSL SCTP THREADS
.if !exists(/usr/sbin/dtrace)
OPTIONS_EXCLUDE+= DTRACE
.endif
OPTIONS_EXCLUDE_DragonFly= HIPE NATIVE SCTP
# ld(1) fails to link probes: missing __dtrace_erlang___* symbols
OPTIONS_EXCLUDE_aarch64= DTRACE
OPTIONS_EXCLUDE_armv6= DTRACE
OPTIONS_EXCLUDE_armv7= DTRACE
OPTIONS_EXCLUDE_i386= DTRACE HIPE NATIVE
OPTIONS_EXCLUDE_powerpc64= HIPE
OPTIONS_EXCLUDE_powerpc64le= HIPE
OPTIONS_EXCLUDE_riscv64= DTRACE
CORBA_DESC= Enable Corba support
DIRTY_DESC= Enable Dirty schedulers
HIPE_DESC= Build native HiPE compiler
KQUEUE_DESC= Enable Kernel Poll (kqueue) support
NATIVE_DESC= Enable native libraries
SCTP_DESC= Enable SCTP support
WX_DESC= Enable WX application
# If you run Erlang and get a message resembling "WARNING: number of
# probes fixed does not match the number of defined probes (54 != 132,
# respectively)" you probably misconfigured DTrace in some way.
DIRTY_CONFIGURE_ENABLE= dirty-schedulers
DTRACE_CONFIGURE_WITH= dynamic-trace=dtrace
DTRACE_CFLAGS= -fno-omit-frame-pointer
DTRACE_VARS= STRIP=""
HIPE_CONFIGURE_ENABLE= hipe
JAVA_CONFIGURE_WITH= javac
JAVA_CONFIGURE_ENV= ac_cv_prog_JAVAC="${JAVAC}"
JAVA_VARS= USE_JAVA=yes
KQUEUE_CONFIGURE_ENABLE= kernel-poll
NATIVE_IMPLIES= HIPE
NATIVE_CONFIGURE_ENABLE= native-libs
ODBC_LIB_DEPENDS= libodbc.so:databases/unixODBC
ODBC_CONFIGURE_WITH= odbc
ODBC_CFLAGS= -I/usr/local/include
ODBC_LDFLAGS= -L/usr/local/lib
OPENSSL_USES= ssl
OPENSSL_CONFIGURE_WITH= ssl=${OPENSSLBASE}
SCTP_CONFIGURE_ENABLE= sctp
THREADS_CONFIGURE_ENABLE= threads
WX_USES= gl
WX_CONFIGURE_WITH= wx-config=${WX_CONFIG}
WX_VARS= USE_GL="gl glu" \
USE_WX=3.1+ \
WX_COMPS="wx"
.include <bsd.port.pre.mk>
.if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 130
# PR 258494
CONFIGURE_ARGS+= --disable-pgo
.endif
.if ${OPSYS} == FreeBSD
CFLAGS+= -DMAP_NORESERVE=0
.endif
.if ${ARCH} == i386
MAKE_ARGS+= ARCH=x86
.endif
.if ${ARCH} == armv6 || ${ARCH} == armv7
MAKE_ARGS+= ARCH=arm
.endif
pre-configure:
@cd ${WRKSRC} && ./otp_build autoconf
pre-configure-WX-off:
echo "disabled by port options" > ${WRKSRC}/lib/debugger/SKIP
echo "disabled by port options" > ${WRKSRC}/lib/et/SKIP
echo "disabled by port options" > ${WRKSRC}/lib/observer/SKIP
echo "disabled by port options" > ${WRKSRC}/lib/wx/SKIP
post-configure-ODBC-on:
${RM} ${WRKSRC}/lib/odbc/SKIP
pre-build-NATIVE-on:
@cd ${WRKSRC} && ${MAKE_CMD} clean
post-build-CORBA-on:
cd ${WRKSRC_corba} \
&& ${SETENV} OVERRIDE_TARGET=${CONFIGURE_TARGET} ERL_TOP=${WRKSRC_otp} ${MAKE_CMD}
post-install-CORBA-on:
cd ${WRKSRC_corba} \
&& ${SETENV} OVERRIDE_TARGET=${CONFIGURE_TARGET} ERL_TOP=${WRKSRC_otp} \
${MAKE_CMD} release RELEASE_ROOT=${STAGEDIR}${PREFIX}/lib/${ERLANG_LIB}
post-install-DTRACE-on:
${MKDIR} ${STAGEDIR}${DATADIR}/dtrace
${INSTALL_DATA} ${WRKSRC}/erts/emulator/beam/*.d \
${WRKSRC}/lib/runtime_tools/c_src/*.d \
${WRKSRC}/lib/runtime_tools/examples/*.d \
${STAGEDIR}${DATADIR}/dtrace
post-install-JAVA-off:
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/jinterface-*
post-install-ODBC-off:
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/odbc-*
post-install-OPENSSL-off:
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/crypto-*
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/ssh-*
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/ssl-*
post-install-WX-off:
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/debugger-*
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/et-*
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/observer-*
${RM} -r ${STAGEDIR}${PREFIX}/lib/erlang/lib/wx-*
post-stage:
${FIND} ${STAGEDIR}${PREFIX}/lib/${ERLANG_LIB}/* -type d -empty -delete
@cd ${STAGEDIR}${PREFIX}; ${FIND} lib/${ERLANG_LIB}/* ${DATADIR_REL}/* -type f -o -type l \
| ${SORT} >> ${TMPPLIST}
.include <bsd.port.post.mk>
View git blame Copy permalink