freebsd-ports/textproc/ispell/files/patch-sec1
Kris Kennaway 557c7a1c70 Create tempfiles securely. Bump PORTREVISION.
Submitted by:   Jarno Huuskonen <Jarno.Huuskonen@uku.fi>
2001-05-29 06:30:45 +00:00

40 lines
1,014 B
Text

--- ispell.c-orig Thu May 24 14:52:00 2001
+++ ispell.c Thu May 24 15:00:06 2001
@@ -802,6 +802,7 @@
{
struct stat statbuf;
char * cp;
+ int fd;
currentfile = filename;
@@ -835,15 +836,20 @@
(void) fstat (fileno (infile), &statbuf);
(void) strcpy (tempfile, TEMPNAME);
- if (mktemp (tempfile) == NULL || tempfile[0] == '\0'
- || (outfile = fopen (tempfile, "w")) == NULL)
- {
- (void) fprintf (stderr, CANT_CREATE,
- (tempfile == NULL || tempfile[0] == '\0')
- ? "temporary file" : tempfile);
- (void) sleep ((unsigned) 2);
- return;
- }
+
+ if ((fd = mkstemp(tempfile)) == -1) {
+ fprintf(stderr, "Error: Can't create (mkstemp) temporary file\n");
+ sleep(2);
+ return;
+ }
+ if ((outfile = fdopen(fd, "w")) == NULL) {
+ unlink(tempfile);
+ close(fd);
+ fprintf(stderr, "Error: Can't open (fdopen) temporary file\n");
+ sleep(2);
+ return;
+ }
+ /* Is this necessary ? */
(void) chmod (tempfile, statbuf.st_mode);
quit = 0;