From 1b9770235de2f7d5d5cc319ebb0612b9f51223bd Mon Sep 17 00:00:00 2001 From: mykola2312 Date: Sun, 31 Mar 2024 19:19:51 +0300 Subject: [PATCH] remove deprecated best_av_format since it useless for youtube now --- src/dl/yt_dlp.rs | 42 ------------------------------------------ 1 file changed, 42 deletions(-) diff --git a/src/dl/yt_dlp.rs b/src/dl/yt_dlp.rs index f76d7b0..22f1629 100644 --- a/src/dl/yt_dlp.rs +++ b/src/dl/yt_dlp.rs @@ -115,38 +115,6 @@ impl YtDlpInfo { } } - #[deprecated( - since = "0.1.1", - note = "for YouTube download audio and video separately" - )] - pub fn best_av_format(&self) -> Option<&YtDlpFormat> { - let format = self - .formats - .iter() - .filter_map(|f| { - if f.vcodec.is_some() && f.acodec.is_some() { - Some(VideoFormat { - format: &f, - format_note: f.format_note.as_ref()?, - width: f.width?, - height: f.height?, - vbr: f.vbr?, - }) - } else { - None - } - }) - .max_by_key(|f| (f.width, f.height)); - - match format { - Some(vf) => Some(vf.format), - None => { - event!(Level::ERROR, "no av format for {}", self.id); - None - } - } - } - pub fn best_audio_format(&self) -> Option<&YtDlpFormat> { let format = self .formats @@ -317,16 +285,6 @@ mod tests { use super::YtDlp; use std::env; - #[tokio::test] - async fn best_av_format() { - dotenv::from_filename(".env.test").unwrap(); - let info = YtDlp::load_info(env::var("TEST_URL").unwrap().as_str()) - .await - .unwrap(); - let video = info.best_av_format().unwrap(); - assert_eq!(video.format_id, "22"); - } - #[tokio::test] async fn best_audio_format() { dotenv::from_filename(".env.test").unwrap();