mykola/rs-tftpd
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add overwrite mode

Browse source
This commit is contained in:
Altuğ Bakan 2023-10-08 15:52:41 +02:00
parent bf7b2a2ee3
commit 3af429fa4a
2 changed files with 55 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/config.rs
View file

@ -31,6 +31,8 @@ pub struct Config {
pub read_only: bool,
/// Duplicate all packets sent from the server. (default: 1)
pub duplicate_packets: u8,
/// Overwrite existing files. (default: false)
pub overwrite: bool,
}
impl Config {
@ -44,6 +46,7 @@ impl Config {
single_port: false,
read_only: false,
duplicate_packets: 1,
overwrite: false,
};
args.next();
@ -92,6 +95,7 @@ impl Config {
println!(" -s, --single-port\t\tUse a single port for both sending and receiving (default: false)");
println!(" -r, --read-only\t\tRefuse all write requests, making the server read-only (default: false)");
println!(" --duplicate-packets <NUM>\tDuplicate all packets sent from the server (default: 0)");
println!(" --overwrite\t\t\tOverwrite existing files (default: false)");
println!(" -h, --help\t\t\tPrint help information");
process::exit(0);
}
@ -111,6 +115,9 @@ impl Config {
return Err("Missing duplicate packets after flag".into());
}
}
"--overwrite" => {
config.overwrite = true;
}
invalid => return Err(format!("Invalid flag: {invalid}").into()),
}

51
src/server.rs
View file

@ -32,6 +32,7 @@ pub struct Server {
directory: PathBuf,
single_port: bool,
read_only: bool,
overwrite: bool,
duplicate_packets: u8,
largest_block_size: usize,
clients: HashMap<SocketAddr, Sender<Packet>>,
@ -47,6 +48,7 @@ impl Server {
directory: config.directory.clone(),
single_port: config.single_port,
read_only: config.read_only,
overwrite: config.overwrite,
duplicate_packets: config.duplicate_packets,
largest_block_size: DEFAULT_BLOCK_SIZE,
clients: HashMap::new(),
@ -94,7 +96,7 @@ impl Server {
{
eprintln!("Could not send error packet");
};
eprintln!("Received invalid request");
eprintln!("Received write request while in read-only mode");
continue;
}
println!("Receiving {filename} from {from}");
@ -194,32 +196,14 @@ impl Server {
to: &SocketAddr,
) -> Result<(), Box<dyn Error>> {
let file_path = &self.directory.join(file_name);
match check_file_exists(file_path, &self.directory) {
ErrorCode::FileExists => Socket::send_to(
&self.socket,
&Packet::Error {
code: ErrorCode::FileExists,
msg: "requested file already exists".to_string(),
},
to,
),
ErrorCode::AccessViolation => Socket::send_to(
&self.socket,
&Packet::Error {
code: ErrorCode::AccessViolation,
msg: "file access violation".to_string(),
},
to,
),
ErrorCode::FileNotFound => {
let initialize_write = &mut || -> Result<(), Box<dyn Error>> {
let worker_options = parse_options(options, RequestType::Write)?;
let mut socket: Box<dyn Socket>;
if self.single_port {
let single_socket = create_single_socket(&self.socket, to)?;
self.clients.insert(*to, single_socket.sender());
self.largest_block_size =
max(self.largest_block_size, worker_options.block_size);
self.largest_block_size = max(self.largest_block_size, worker_options.block_size);
socket = Box::new(single_socket);
} else {
@ -240,7 +224,32 @@ impl Server {
self.duplicate_packets,
);
worker.receive()
};
match check_file_exists(file_path, &self.directory) {
ErrorCode::FileExists => {
if self.overwrite {
initialize_write()
} else {
Socket::send_to(
&self.socket,
&Packet::Error {
code: ErrorCode::FileExists,
msg: "requested file already exists".to_string(),
},
to,
)
}
}
ErrorCode::AccessViolation => Socket::send_to(
&self.socket,
&Packet::Error {
code: ErrorCode::AccessViolation,
msg: "file access violation".to_string(),
},
to,
),
ErrorCode::FileNotFound => initialize_write(),
_ => Err("Unexpected error code when checking file".into()),
}
}